support sentinel myid subcommand#7858
Merged
oranagra merged 1 commit intoredis:unstablefrom Oct 5, 2020
Merged
Conversation
itamarhaber
approved these changes
Sep 29, 2020
itamarhaber
added
class:feature
state:major-decision
oranagra
approved these changes
Sep 29, 2020
yossigo
approved these changes
Sep 29, 2020
oranagra
added
the
state:to-be-merged
Member
|
@hwware thanks. can you make a redis-doc PR as well? |
Contributor
Author
|
hi @oranagra , will do. thanks for the reminder. |
Contributor
Author
|
hi @oranagra,please review this doc pr redis/redis-doc#1418, thanks. Please note there are some commands missing except the sentinel myid one, i added all the missing commands back in that pr. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
18 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit provides a fast way to get current sentinel id. Similar to Cluster myid subcommand. Currently there is no good way to get current sentinel id, other than jumping to the top of sentinel run log file when sentinel starts. Getting sentinel id would be helpful when analysing sentinel behaviour in logs, such as:
1958:X 15 Apr 19:36:46.426 # +try-failover master redisroute144200262587 10.133.0.56 6379
1958:X 15 Apr 19:36:46.430 # +vote-for-leader b7b5e68f89e1593427afde670b7c1ff5bc1fbe8f 14
1958:X 15 Apr 19:36:46.440 # 24f3ea9e48876738c8ed52a3f2fe5f0f9d9fdd81 voted for b7b5e68f89e1593427afde670b7c1ff5bc1fbe8f 14