Add GET parameter to SET command#7852
Merged
oranagra merged 1 commit intoredis:unstablefrom Oct 2, 2020
Merged
Conversation
oranagra
reviewed
Sep 28, 2020
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
these tests are so simple and fast, let's also add a test for XX and EX.
Can you please also make a PR for redis-doc?
mark it as starting redis 6.2, and mark GETSET as deprecated the same way HMSET is marked.
nykolaslima
force-pushed
the
add-get-parameter-to-set
branch
3 times, most recently
from
fb77574 to
a9b0572
Compare
Contributor
Author
Closes redis#2349 Add optional GET parameter to SET command in order to set a new value to a key and retrieve the old key value. With this change we can deprecate `GETSET` command and use only the SET command with the GET parameter.
nykolaslima
force-pushed
the
add-get-parameter-to-set
branch
from
a9b0572 to
6094b42
Compare
Contributor
Author
|
@oranagra any other comments on this? I believe we're good to go. |
oranagra
approved these changes
Sep 30, 2020
Member
|
@redis/core-team please approve |
yossigo
approved these changes
Sep 30, 2020
itamarhaber
approved these changes
Oct 2, 2020
This was referenced Oct 2, 2020
Closed
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Add optional GET parameter to SET command in order to set a new value to a key and retrieve the old key value. With this change we can deprecate `GETSET` command and use only the SET command with the GET parameter.
oranagra
added
the
release-notes
18 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2349
Add optional GET parameter to SET command in order to set a new value to
a key and retrieve the old key value. With this change we can deprecate
GETSETcommand and use only the SET command with the GET parameter.@oranagra