Don't support Gopher if enable io threads to read queries#7851
Merged
oranagra merged 3 commits intoredis:unstablefrom Sep 27, 2020
Merged
Don't support Gopher if enable io threads to read queries#7851oranagra merged 3 commits intoredis:unstablefrom
oranagra merged 3 commits intoredis:unstablefrom
Conversation
If you enable Gopher, you also must disable 'io-threads-do-reads' to avoid data race in Gopher handler, otherwise, Redis will not support Gopher.
oranagra
reviewed
Sep 27, 2020
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
in theory we can detect when the combination is used and error (either error the config set command, or fail at startup).
but i don't think we wanna bother by adding 10 more lines of code to do that.
i think it's enough to just have Gopher not work.
What do you think?
Co-authored-by: Oran Agra <[email protected]>
Member
Author
|
Yes, I agree. We needn't spend much energy on this. |
oranagra
reviewed
Sep 27, 2020
oranagra
approved these changes
Sep 27, 2020
oranagra
changed the title
oranagra
pushed a commit
that referenced
this pull request
Oct 27, 2020
There's currently an issue with IO threads and gopher (issuing lookupKey from within the thread). simply fix is to just not support it for now. (cherry picked from commit c9f00bc)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
There's currently an issue with IO threads and gopher (issuing lookupKey from within the thread). simply fix is to just not support it for now.
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
There's currently an issue with IO threads and gopher (issuing lookupKey from within the thread). simply fix is to just not support it for now. (cherry picked from commit c9f00bc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7779
If you enable Gopher, you also must disable 'io-threads-do-reads' to avoid data race in Gopher handler, otherwise, Redis will
not support Gopher.