Skip to content

warning: comparison between signed and unsigned integer in 32bit build#7838

Merged
oranagra merged 1 commit intoredis:unstablefrom
oranagra:fix_32bit_warnings
Sep 29, 2020
Merged

warning: comparison between signed and unsigned integer in 32bit build#7838
oranagra merged 1 commit intoredis:unstablefrom
oranagra:fix_32bit_warnings

Conversation

@oranagra
Copy link
Member

numele can't be more than 65k, and we already know index is non-negative from an earlier check

@oranagra oranagra requested a review from yossigo September 24, 2020 07:17
@oranagra oranagra added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label Sep 29, 2020
@oranagra oranagra merged commit ef33252 into redis:unstable Sep 29, 2020
@oranagra oranagra deleted the fix_32bit_warnings branch September 29, 2020 14:03
oranagra added a commit that referenced this pull request Oct 27, 2020
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants