Skip to content

Fix redundancy use of semicolon in do-while macros in ziplist.c.#7832

Merged
oranagra merged 1 commit intoredis:unstablefrom
trevor211:fixRedundancy
Sep 23, 2020
Merged

Fix redundancy use of semicolon in do-while macros in ziplist.c.#7832
oranagra merged 1 commit intoredis:unstablefrom
trevor211:fixRedundancy

Conversation

@trevor211
Copy link
Contributor

Fixes #5591

Copy link
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh my, this is dangerous!
luckily it seems it didn't cause any bugs, and this fix doesn't change the behavior at all.
also, luckily it seems it doesn't have any conflicts with #7807

@oranagra oranagra changed the title Fix redundancy use of semicolon in some macros in ziplist.c. Fix redundancy use of semicolon in do-while macros in ziplist.c. Sep 23, 2020
@oranagra oranagra merged commit 63cd4d4 into redis:unstable Sep 23, 2020
@trevor211 trevor211 deleted the fixRedundancy branch October 13, 2020 08:22
oranagra pushed a commit that referenced this pull request Oct 27, 2020
this is very dangerous bug, but it looks like it didn't cause any harm.

(cherry picked from commit 63cd4d4)
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
…is#7832)

this is very dangerous bug, but it looks like it didn't cause any harm.
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
…is#7832)

this is very dangerous bug, but it looks like it didn't cause any harm.

(cherry picked from commit 63cd4d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redundancy and misspelling in ziplist.c

2 participants