Fix occasional hangs on replication reconnection.#7830
Merged
yossigo merged 1 commit intoredis:unstablefrom Sep 22, 2020
Merged
Fix occasional hangs on replication reconnection.#7830yossigo merged 1 commit intoredis:unstablefrom
yossigo merged 1 commit intoredis:unstablefrom
Conversation
After reconnection is initiated, replicationEmptyDbCallback() may get called and try to write to an unconnected socket. This trigerred another issue where the connection is put into an error state and the connect handler never gets called. This problem reproduced quite frequently running tests on MacOS.
Member
|
@yossigo so this happens only in diskless replica, right? the reason we saw it rarely is because the database in that test wasn't very large. but on larger databases that take longer to flush, this is actually almost guaranteed? i wanna know all the details so that we can put them into the commit comment when squashing and then consider cherry picking. |
oranagra
approved these changes
Sep 22, 2020
Collaborator
Author
|
@oranagra updated description with all the details. |
oranagra
pushed a commit
that referenced
this pull request
Oct 27, 2020
This happens only on diskless replicas when attempting to reconnect after failing to load an RDB file. It is more likely to occur with larger datasets. After reconnection is initiated, replicationEmptyDbCallback() may get called and try to write to an unconnected socket. This triggered another issue where the connection is put into an error state and the connect handler never gets called. The problem is a regression introduced by commit c17e597. (cherry picked from commit 1980f63)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
This happens only on diskless replicas when attempting to reconnect after failing to load an RDB file. It is more likely to occur with larger datasets. After reconnection is initiated, replicationEmptyDbCallback() may get called and try to write to an unconnected socket. This triggered another issue where the connection is put into an error state and the connect handler never gets called. The problem is a regression introduced by commit c17e597.
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
This happens only on diskless replicas when attempting to reconnect after failing to load an RDB file. It is more likely to occur with larger datasets. After reconnection is initiated, replicationEmptyDbCallback() may get called and try to write to an unconnected socket. This triggered another issue where the connection is put into an error state and the connect handler never gets called. The problem is a regression introduced by commit c17e597. (cherry picked from commit 1980f63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens only on diskless replicas when attempting to reconnect after failing to load an RDB file. It is more likely to occur with larger datasets.
After reconnection is initiated,
replicationEmptyDbCallback()may get called and try to write to an unconnected socket. This triggered another issue where the connection is put into an error state and the connect handler never gets called. The problem is a regression introduced by commit c17e597.