[BUG] redis-check-rdb support for auxiliary from modules#7826
Merged
oranagra merged 5 commits intoredis:unstablefrom Sep 22, 2020
Merged
[BUG] redis-check-rdb support for auxiliary from modules#7826oranagra merged 5 commits intoredis:unstablefrom
oranagra merged 5 commits intoredis:unstablefrom
Conversation
oranagra
reviewed
Sep 21, 2020
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
jut to be sure, have you tested it on an RDB file with a "before" module aux entry?
i.e. to be sure it can continue parsing the file cleanly after it..
Co-authored-by: Oran Agra <[email protected]>
oranagra
reviewed
Sep 21, 2020
oranagra
reviewed
Sep 22, 2020
ashtul
commented
Sep 22, 2020
oranagra
previously approved these changes
Sep 22, 2020
oranagra
approved these changes
Sep 22, 2020
Merged
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
redis-check-rdb was unable to parse rdb files containing module aux data. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 63a05dd)
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
redis-check-rdb was unable to parse rdb files containing module aux data. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 63a05dd)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
redis-check-rdb was unable to parse rdb files containing module aux data. Co-authored-by: Oran Agra <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
redis-check-rdb was unable to parse rdb files containing module aux data. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 63a05dd)
pulllock
pushed a commit
to pulllock/redis
that referenced
this pull request
Jun 28, 2023
redis-check-rdb was unable to parse rdb files containing module aux data. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 63a05dd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7808