Fix C11 detection in the makefile#7822
Merged
oranagra merged 1 commit intoredis:unstablefrom Sep 21, 2020
oranagra:fix_c11_detection
Merged
Fix C11 detection in the makefile#7822oranagra merged 1 commit intoredis:unstablefrom oranagra:fix_c11_detection
oranagra merged 1 commit intoredis:unstablefrom
oranagra:fix_c11_detection
Conversation
445a4b6 introudced a makefile script that detects if the toolchain supports c11, and it looked that it was passing on MacOS and fails on Ubuntu, looks like Ubuntu's Dash was spawning a background process, deleted foo.c before gcc tried to compile it.
Member
|
We use |
Member
Author
|
yeah |
yossigo
approved these changes
Sep 21, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
445a4b6 introudced a makefile script that detects if the toolchain supports c11, and it looked that it was passing on MacOS and fails on Ubuntu, looks like Ubuntu's Dash was spawning a background process, deleted foo.c before gcc tried to compile it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
445a4b6 introudced a makefile script that detects if the toolchain
supports c11, and it looked that it was passing on MacOS and fails on
Ubuntu, looks like Ubuntu's Dash was spawning a background process,
deleted foo.c before gcc tried to compile it.