fix make warnings in debug.c#7805
Merged
oranagra merged 2 commits intoredis:unstablefrom Sep 20, 2020
Merged
Conversation
ShooterIT
reviewed
Sep 17, 2020
Member
|
@daidaotong thanks. how about just remove the additionally we can also declare it in server.h next to |
Contributor
Author
|
hi @oranagra @ShooterIT , please review the new changes regarding these comments. thanks! |
oranagra
approved these changes
Sep 20, 2020
oranagra
added a commit
that referenced
this pull request
Oct 27, 2020
Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 1b3b752)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Co-authored-by: Oran Agra <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 1b3b752)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes build warning:
debug.c:1583:13: warning: unused function 'killThreads' [-Wunused-function]
static void killThreads(void) {
^
the killThreads and killMainThread function are only used in #if defined(HAVE_PROC_MAPS) block, therefore we can avoid the make warnings by enlarging the condition block.