Fix warning from jemalloc configure script#7790
Merged
oranagra merged 1 commit intoredis:unstablefrom Sep 21, 2020
yoonghm:redis-7784-b
Merged
Fix warning from jemalloc configure script#7790oranagra merged 1 commit intoredis:unstablefrom yoonghm:redis-7784-b
oranagra merged 1 commit intoredis:unstablefrom
yoonghm:redis-7784-b
Conversation
`--enable-cc-silence` was already removed from `configure.ac` file in the newer version of jemalloc library. It is time to update Makefile.
Contributor
Author
|
This is also removed in https://github.com/jemalloc/jemalloc/blob/dev/configure.ac and not used already in the jemalloc version within the latest redis code. |
oranagra
approved these changes
Sep 21, 2020
oranagra
changed the title
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
jemalloc configure shows this:
configure: WARNING: unrecognized options: --enable-cc-silence
The changelog of jemalloc 4.0 has:
- Replace --enable-cc-silence with --disable-cc-silence to suppress spurious
warnings by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--enable-cc-silencewas already removed fromconfigure.acfile in the newer version of jemalloc library. It is time to update Makefile.