Fix loading of save params from config file.#7767
Merged
yossigo merged 1 commit intoredis:unstablefrom Sep 9, 2020
Merged
Conversation
oranagra
previously approved these changes
Sep 9, 2020
oranagra
previously approved these changes
Sep 9, 2020
Member
|
@itamarhaber FYI: #7092 introduced a bug. @yossigo please include that info in the commit comment when you squash-merge it. |
oranagra
reviewed
Sep 9, 2020
Save parameters should either be default or whatever specified in the config file. This fixes an issue introduced in redis#7092 which causes configuration file settings to be applied on top of the defaults.
yossigo
force-pushed
the
fix-config-save
branch
from
3f61d7e to
84ddca8
Compare
yossigo
changed the title
oranagra
approved these changes
Sep 9, 2020
oranagra
added
the
release-notes
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Save parameters should either be default or whatever specified in the config file. This fixes an issue introduced in redis#7092 which causes configuration file settings to be applied on top of the defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save parameters should either be default or whatever specified in the
config file. This fixes an issue introduced in #7092 which causes
configuration file settings to be applied on top of the defaults.