Allow exec with read commands on readonly replica in cluster#7766
Merged
oranagra merged 6 commits intoredis:unstablefrom Sep 9, 2020
eliblight:Issue#7683-MULTI/EXEC-on-READONLY-replica
Merged
Allow exec with read commands on readonly replica in cluster#7766oranagra merged 6 commits intoredis:unstablefrom eliblight:Issue#7683-MULTI/EXEC-on-READONLY-replica
oranagra merged 6 commits intoredis:unstablefrom
eliblight:Issue#7683-MULTI/EXEC-on-READONLY-replica
Conversation
Pull from antirez/redis (i.e. update private fork)
Pull redis/redis : unstable
Add/fix the ability to preform a MULTI/EXEC transaction which consist of only readonly operations (each indiviually allowed on a replica)
Tests MULTI/EXEC operation on a replica
oranagra
previously approved these changes
Sep 9, 2020
Adds a new empty line at the end of the file Co-authored-by: Oran Agra <[email protected]>
oranagra
approved these changes
Sep 9, 2020
oranagra
changed the title
oranagra
added a commit
that referenced
this pull request
Sep 10, 2020
There was a bug. Although cluster replicas would allow read commands, they would not allow a MULTI-EXEC that's composed solely of read commands. Adds tests for coverage. Co-authored-by: Oran Agra <[email protected]> Co-authored-by: Eran Liberty <[email protected]> (cherry picked from commit b120366)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
) There was a bug. Although cluster replicas would allow read commands, they would not allow a MULTI-EXEC that's composed solely of read commands. Adds tests for coverage. Co-authored-by: Oran Agra <[email protected]> Co-authored-by: Eran Liberty <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
) There was a bug. Although cluster replicas would allow read commands, they would not allow a MULTI-EXEC that's composed solely of read commands. Adds tests for coverage. Co-authored-by: Oran Agra <[email protected]> Co-authored-by: Eran Liberty <[email protected]> (cherry picked from commit b120366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #7683 adds the ability to do MULTI/EXEC read only operations on a READONLY replica.
Minor: