Tests: Add aclfile load and save tests#7765
Conversation
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
@yangbodong22011 may i ask what's the trigger to adding this test? i understand we're lacking coverage, but i assume there was some reason for adding it now.
while you're at it, maybe you can also add coverage for ACL SAVE and ACL LOAD
|
Yes, please also add |
I wanted to use aclfile, but found that it lacked tests, so I added tests. |
yangbodong22011
force-pushed
the
feature-add-aclfile-test
branch
2 times, most recently
from
cf334ad to
7caeef4
Compare
tests/unit/acl.tcl
Outdated
There was a problem hiding this comment.
these assertions are not needed.. if the command errors, the test will fail anyway (throws an exception).
you need this only if you're expecting different success responses (e.g. a number of an array)
There was a problem hiding this comment.
Thanks, already updated.
yangbodong22011
force-pushed
the
feature-add-aclfile-test
branch
from
7caeef4 to
97ac74d
Compare
oranagra
changed the title
improves test coverage (cherry picked from commit 0666267)
improves test coverage
improves test coverage (cherry picked from commit 0666267)
3 participants
Add aclfile load tests.