Tests: validate CONFIG REWRITE for all params.#7764
Merged
yossigo merged 2 commits intoredis:unstablefrom Sep 9, 2020
Merged
Conversation
oranagra
previously approved these changes
Sep 8, 2020
Member
|
how about adding another step that matches the CONFIG GET responses from the restarted server to the ones from before the restart? |
oranagra
approved these changes
Sep 9, 2020
oranagra
previously approved these changes
Sep 9, 2020
This is a catch-all test to confirm that that rewrite produces a valid output for all parameters.
yossigo
force-pushed
the
test-config-rewrite
branch
from
64c76e1 to
fa1b78a
Compare
oranagra
approved these changes
Sep 9, 2020
oranagra
pushed a commit
that referenced
this pull request
Sep 10, 2020
This is a catch-all test to confirm that that rewrite produces a valid output for all parameters and that this process does not introduce undesired configuration changes. (cherry picked from commit a8b7268)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
This is a catch-all test to confirm that that rewrite produces a valid output for all parameters and that this process does not introduce undesired configuration changes.
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
This is a catch-all test to confirm that that rewrite produces a valid output for all parameters and that this process does not introduce undesired configuration changes. (cherry picked from commit a8b7268)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a catch-all test to confirm that that rewrite produces a valid
output for all parameters.