Skip to content

Fix CONFIG REWRITE of oom-score-adj-values.#7761

Merged
yossigo merged 1 commit intoredis:unstablefrom
yossigo:fix-oom-score-adj-values-rewrite
Sep 8, 2020
Merged

Fix CONFIG REWRITE of oom-score-adj-values.#7761
yossigo merged 1 commit intoredis:unstablefrom
yossigo:fix-oom-score-adj-values-rewrite

Conversation

@yossigo
Copy link
Collaborator

@yossigo yossigo commented Sep 8, 2020

Fixes #7760

@yossigo yossigo requested a review from oranagra September 8, 2020 12:50
@yossigo yossigo merged commit 750acf3 into redis:unstable Sep 8, 2020
@yossigo yossigo deleted the fix-oom-score-adj-values-rewrite branch September 8, 2020 13:00
oranagra pushed a commit that referenced this pull request Sep 10, 2020
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
@momomo
Copy link

momomo commented Feb 9, 2021

Link: https://redis.io/topics/config

Still includes the flawed config files leaving to a bunch of waste of time. Fix that too. What is the fix now? It is not clear.
Comment out 'oom-score-adj no' ?

*** FATAL CONFIG FILE ERROR (Redis 6.0.6) ***
Reading the configuration file, at line 1062

'oom-score-adj no'
Bad directive or wrong number of arguments
j@j-server-101:/c/configuration/redis/6/server

@oranagra
Copy link
Member

oranagra commented Feb 9, 2021

@momomo this was a bug in 6.0.7 that's fixed in 6.0.8.
it looks like you're using 6.0.6, that does not support this config at all

@momomo
Copy link

momomo commented Feb 9, 2021

@oranagra that was quick! so comment out the two in 6.0.6 ?

@oranagra
Copy link
Member

oranagra commented Feb 9, 2021

yes

@momomo
Copy link

momomo commented Feb 9, 2021

ubuntu 18 still defaults to 6.0.6 it seems. maybe time to update the configs. seems like version 6.08 should be 7 ... since the config files differ so much.

@momomo
Copy link

momomo commented Feb 9, 2021

@momomo
Copy link

momomo commented Feb 9, 2021

where do i find the default redis config for my installation?

@momomo
Copy link

momomo commented Feb 9, 2021

/etc/redis/redis.conf maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRASH] Redis Sentinel rewrite redis.conf by incorrect parameter

4 participants