RM_ThreadSafeContextTryLock a non-blocking method for acquiring GIL#7738
RM_ThreadSafeContextTryLock a non-blocking method for acquiring GIL#7738oranagra merged 2 commits intoredis:unstablefrom
Conversation
oranagra
left a comment
There was a problem hiding this comment.
i wanna reduce the number of units and modules we have (less boilerplate code)
i think it would be better to rename the test unit and module to something more generic so that it'll be natural to add more tests to it in the future.
i see we have one test named blockedkeys, so maybe rename this one to blockedclient?
another alternative is to rename the existing test to just blocked so that we can merge them both into the same module and unit?
f93a45e to
dce1864
Compare
|
@redis/core-team adding a trivial API, please approve. |
|
Two more requests:
|
|
@oranagra Why manipulate |
|
IMHO it feels more natural and matches the rest of the API. We don't have any module API that returns errno (yet). |
|
After discussing this with @oranagra, our conclusions are:
|
|
@yossigo sure thing. |
|
Turns out This is a suggested workaround: In this case I suggest we revert. |
|
yes, let's revert.. |
|
@oranagra I am not in favor of a Module API that is OS specific and may or may not be available regardless of Redis version. We can just not support timeouts. |
34a70fa to
196d2be
Compare
|
@redis/core-team please approve. |
yossigo
left a comment
There was a problem hiding this comment.
Added a couple of nitpick comments, not mandatory.
Co-authored-by: Yossi Gottlieb <[email protected]>
…7738) Co-authored-by: Yossi Gottlieb <[email protected]> Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 042189f)
…edis#7738) Co-authored-by: Yossi Gottlieb <[email protected]> Co-authored-by: Oran Agra <[email protected]>
…edis#7738) Co-authored-by: Yossi Gottlieb <[email protected]> Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 042189f)
No description provided.