Skip to content

Fix double-make issue with make && make install.#7734

Merged
yossigo merged 1 commit intoredis:unstablefrom
yossigo:double-make-fix
Sep 1, 2020
Merged

Fix double-make issue with make && make install.#7734
yossigo merged 1 commit intoredis:unstablefrom
yossigo:double-make-fix

Conversation

@yossigo
Copy link
Collaborator

@yossigo yossigo commented Aug 31, 2020

All user-supplied variables that affect the build should be explicitly
persisted.

Fixes #7254

@yossigo
Fix double-make issue with make && make install.
ef4beef 
All user-supplied variables that affect the build should be explicitly
persisted.

Fixes redis#7254
@oranagra
Copy link
Member

oranagra commented Aug 31, 2020

@yossigo what about BUILD_WITH_SYSTEMD?
see https://github.com/redis/redis/pull/7730/files

@oranagra
Copy link
Member

oranagra commented Aug 31, 2020

actually now that i gave a deeper look at the Makefile, looks like the mention of BUILD_WITH_SYSTEMD in the README is a mistake. @literakl ?

@literakl
Copy link
Contributor

literakl commented Sep 1, 2020

Hi, I have followed this thread: #7217. I copied that command and it helped me. There were no systemd issues afterwards. I do not see libsystemd twice in my build:

[dev@vm1 ~]$ ldd /opt/app/redis/default/bin/redis-server
linux-vdso.so.1 => (0x00007ffc63bcf000)
libm.so.6 => /lib64/libm.so.6 (0x00007f59d0791000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f59d058d000)
librt.so.1 => /lib64/librt.so.1 (0x00007f59d0385000)
libsystemd.so.0 => /lib64/libsystemd.so.0 (0x00007f59d0154000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f59cff38000)
libc.so.6 => /lib64/libc.so.6 (0x00007f59cfb6a000)
/lib64/ld-linux-x86-64.so.2 (0x00007f59d0a93000)
libcap.so.2 => /lib64/libcap.so.2 (0x00007f59cf965000)
libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f59cf73e000)
liblzma.so.5 => /lib64/liblzma.so.5 (0x00007f59cf518000)
liblz4.so.1 => /lib64/liblz4.so.1 (0x00007f59cf303000)
libgcrypt.so.11 => /lib64/libgcrypt.so.11 (0x00007f59cf082000)
libgpg-error.so.0 => /lib64/libgpg-error.so.0 (0x00007f59cee7d000)
libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f59cec63000)
libdw.so.1 => /lib64/libdw.so.1 (0x00007f59cea12000)
libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f59ce7fc000)
libattr.so.1 => /lib64/libattr.so.1 (0x00007f59ce5f7000)
libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f59ce395000)
libelf.so.1 => /lib64/libelf.so.1 (0x00007f59ce17d000)
libz.so.1 => /lib64/libz.so.1 (0x00007f59cdf67000)
libbz2.so.1 => /lib64/libbz2.so.1 (0x00007f59cdd57000)

@yossigo
Copy link
Collaborator Author

yossigo commented Sep 1, 2020

The README seems wrong, BUILD_WITH_SYSTEMD is an internal variable. Users should use USE_SYSTEMD=yes.

@yossigo yossigo merged commit b35d6e5 into redis:unstable Sep 1, 2020
@literakl
Copy link
Contributor

literakl commented Sep 1, 2020 via email

xindoo pushed a commit to xindoo/redis that referenced this pull request Sep 1, 2020
@yossigo @xindoo
Fix double-make issue with make && make install. (redis#7734)
37daccc 
All user-supplied variables that affect the build should be explicitly
persisted.

Fixes redis#7254
@oranagra
Copy link
Member

oranagra commented Sep 1, 2020 •
edited
Loading

readme fixed in #7739

JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Sep 2, 2020
@yossigo
Fix double-make issue with make && make install. (redis#7734)
5a1ca85 
All user-supplied variables that affect the build should be explicitly
persisted.

Fixes redis#7254
oranagra pushed a commit that referenced this pull request Sep 10, 2020
@yossigo @oranagra
Fix double-make issue with make && make install. (#7734)
da33a18 
All user-supplied variables that affect the build should be explicitly
persisted.

Fixes #7254

(cherry picked from commit b35d6e5)
jschmieg pushed a commit to memKeyDB/memKeyDB that referenced this pull request Nov 6, 2020
@yossigo @jschmieg
Fix double-make issue with make && make install. (redis#7734)
cf4584c 
All user-supplied variables that affect the build should be explicitly
persisted.

Fixes redis#7254

(cherry picked from commit b35d6e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra oranagra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make && make install compiles redis twice

3 participants

@yossigo @oranagra @literakl