Skip to content

TLS: support cluster/replication without tls-port.#7573

Merged
yossigo merged 1 commit intoredis:unstablefrom
yossigo:tls-without-tls-port
Jul 27, 2020
Merged

TLS: support cluster/replication without tls-port.#7573
yossigo merged 1 commit intoredis:unstablefrom
yossigo:tls-without-tls-port

Conversation

@yossigo
Copy link
Collaborator

@yossigo yossigo commented Jul 27, 2020

Initialize and configure OpenSSL even when tls-port is not used, because
we may still have tls-cluster or tls-replication.

Also, make sure to reconfigure OpenSSL when these parameters are changed
as TLS could have been enabled for the first time.

Fixes #7565

Initialize and configure OpenSSL even when tls-port is not used, because
we may still have tls-cluster or tls-replication.

Also, make sure to reconfigure OpenSSL when these parameters are changed
as TLS could have been enabled for the first time.
@yossigo yossigo requested a review from oranagra July 27, 2020 11:06
Copy link
Member

@oranagra oranagra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yossigo do you wanna add a test to cover this? or do you think the manual test which i assume you did is enough?

@yossigo
Copy link
Collaborator Author

yossigo commented Jul 27, 2020

@oranagra I think it's pretty trivial

@yossigo yossigo merged commit 5f4a280 into redis:unstable Jul 27, 2020
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Aug 4, 2020
Initialize and configure OpenSSL even when tls-port is not used, because
we may still have tls-cluster or tls-replication.

Also, make sure to reconfigure OpenSSL when these parameters are changed
as TLS could have been enabled for the first time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis 6.0.6 crash with SiGSEGV in SSL_set_fd at startup

2 participants