Fix: check SSL_new fail#7569
Closed
mrpre wants to merge 1 commit intoredis:unstablefrom
mrpre:sslnewcheck
Closed
Conversation
Collaborator
Collaborator
|
Fixed by #7576 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #7565
(1). Redis miss the return value check of
SSL_new.(2). It' disgusting for redis to check whether
sslis null ifconnCreateAcceptedxxxreturns an allocatedconnwith nullsslitem, so I just free theconninside the theconnCreateAcceptedxxx. May be we should add such api likeconnSuccess(xx)to check the connection.(3). Since (2), I think the TLS will not be the only protocol to be used in the future which means
connCreateAcceptedxxxis likely to return null andacceptCommonHandlershould be protected.more detail: