Recalculate hardcoded variables from $::instances_count in sentinel tests#7561
Merged
yossigo merged 2 commits intoredis:unstablefrom Sep 13, 2020
Merged
Conversation
mykhailopylyp
changed the title
yossigo
requested changes
Sep 8, 2020
Collaborator
yossigo
left a comment
yossigo
left a comment
There was a problem hiding this comment.
@mykhailopylyp thanks for this PR, it looks good! Can you please remove trailing white spaces before it is merged? Thanks
yossigo
approved these changes
Sep 13, 2020
Collaborator
|
Thank you @mykhailopylyp ! |
oranagra
pushed a commit
that referenced
this pull request
Oct 27, 2020
…ests (#7561) Co-authored-by: MemuraiUser <[email protected]> (cherry picked from commit cb2c7c4)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
…ests (redis#7561) Co-authored-by: MemuraiUser <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
…ests (redis#7561) Co-authored-by: MemuraiUser <[email protected]> (cherry picked from commit cb2c7c4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not enough to change
$::instances_countto run sentinel tests on more instances than five because some tests assume that there are exactly five instances. These changes refactor such tests.