Skip to content

Fix comments in listpack.c#7402

Merged
antirez merged 2 commits intoredis:unstablefrom
chenhui0212:unstable
Jun 18, 2020
Merged

Fix comments in listpack.c#7402
antirez merged 2 commits intoredis:unstablefrom
chenhui0212:unstable

Conversation

@chenhui0212
Copy link
Contributor

fix comments in listpack.c

@antirez
Copy link
Contributor

antirez commented Jun 16, 2020

I agree @chenhui0212, thanks. However shouldn't we also fix "Left to right scanning always expects a..." comment a few lines above?

@chenhui0212
Copy link
Contributor Author

Thanks for your reply @antirez You're right, I missed that comment. It's also fixed now.

@antirez
Copy link
Contributor

antirez commented Jun 18, 2020

Thanks @chenhui0212

@antirez antirez merged commit 5e46e08 into redis:unstable Jun 18, 2020
@chenhui0212
Copy link
Contributor Author

@antirez I made a mistake, I'm sorry for the second commit (f800b52), When I realized it, it was just merged. I should have fixed it on a new branch, Is anything I can do?

JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants