EAGAIN not handled for TLS during diskless load#7305
Merged
antirez merged 1 commit intoredis:unstablefrom May 22, 2020
Merged
Conversation
Member
Contributor
|
Thanks @madolson |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Jun 18, 2020
EAGAIN not handled for TLS during diskless load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TLS, we might not have read in a full frame, so there is data on the connection so epoll fires, but there isn't enough data to actually read from the socket.
Not sure how common this is, we have some testing that randomly fragments TLS packets to catch some of this stuff. I don't think this can happen for TCP.