fix unstable replication test#7240
Merged
antirez merged 1 commit intoredis:unstablefrom May 12, 2020
oranagra:fix_replication_test
Merged
fix unstable replication test#7240antirez merged 1 commit intoredis:unstablefrom oranagra:fix_replication_test
antirez merged 1 commit intoredis:unstablefrom
oranagra:fix_replication_test
Conversation
this test which has coverage for varoius flows of diskless master was failing randomly from time to time. the failure was: [err]: diskless all replicas drop during rdb pipe in tests/integration/replication.tcl log message of '*Diskless rdb transfer, last replica dropped, killing fork child*' not found what seemed to have happened is that the master didn't detect that all replicas dropped by the time the replication ended, it thought that one replica is still connected. now the test takes a few seconds longer but it seems stable.
Contributor
|
Thank you @oranagra |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
May 15, 2020
fix unstable replication test
Member
Author
|
looks like this broke the daily valgrind runs. need to look into it. |
Contributor
|
@oranagra well always broken for me in the CI I run, so no change :-) But yep better to go in the direction of fixing it. |
Member
Author
|
hopefully fixed in #7271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test which has coverage for varoius flows of diskless master was
failing randomly from time to time.
the failure was:
what seemed to have happened is that the master didn't detect that all
replicas dropped by the time the replication ended, it thought that one
replica is still connected.
now the test takes a few seconds longer but it seems stable.