Merged
Conversation
Contributor
|
Thanks @braddunbar, merged. Indeed the conditional is not needed. Moreover as I opened the file, I did a quick review and found two issues fixed in e17f931: this code was converted from code that was using C strings and called strlen() to get the length of the two strings. However in the new form, there is no guarantee that the strings will be null terminated (even if we probably call the code always with null terminated stings). |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
May 15, 2020
Remove unreachable branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stringLencan never be0here because it was checked in thewhilecondition.