fix loading race in psync2 tests#7155
Merged
antirez merged 1 commit intoredis:unstablefrom Apr 28, 2020
oranagra:psync2_tests_race
Merged
fix loading race in psync2 tests#7155antirez merged 1 commit intoredis:unstablefrom oranagra:psync2_tests_race
antirez merged 1 commit intoredis:unstablefrom
oranagra:psync2_tests_race
Conversation
Contributor
|
Thank you @oranagra, we should have functions that automatically do checks and automatically call wait_for_condition letting us to verify things, and making sure to do certain checks. |
Member
Author
|
@antirez i now realize that this should actually never happen in these tests. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
May 15, 2020
fix loading race in psync2 tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antirez another race in the various psync2 tests. they can try to do DBSIZE or GET too early and get -LOADING error.