allow dictFind using static robj#7152
Merged
antirez merged 1 commit intoredis:unstablefrom Apr 27, 2020
oranagra:dict_find_static_robj
Merged
allow dictFind using static robj#7152antirez merged 1 commit intoredis:unstablefrom oranagra:dict_find_static_robj
antirez merged 1 commit intoredis:unstablefrom
oranagra:dict_find_static_robj
Conversation
since the recent addition of OBJ_STATIC_REFCOUNT and the assertion in incrRefCount it is now impossible to use dictFind using a static robj, because dictEncObjKeyCompare will call getDecodedObject which tries to increment the refcount just in order to decrement it later.
Member
Author
|
@antirez problem was found in ROF, but could still be hiding in redis somewhere. |
Contributor
|
@oranagra well it looks good enough to me. I'm merging and just fixing the comment that says the other function name. Thank you. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Apr 28, 2020
allow dictFind using static robj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the recent addition of OBJ_STATIC_REFCOUNT and the assertion in
incrRefCount it is now impossible to use dictFind using a static robj,
because dictEncObjKeyCompare will call getDecodedObject which tries to
increment the refcount just in order to decrement it later.