optimize memory usage of deferred replies#7146
Merged
antirez merged 1 commit intoredis:unstablefrom Apr 27, 2020
oranagra:optimize_deferred_reply
Merged
optimize memory usage of deferred replies#7146antirez merged 1 commit intoredis:unstablefrom oranagra:optimize_deferred_reply
antirez merged 1 commit intoredis:unstablefrom
oranagra:optimize_deferred_reply
Conversation
When deffered reply is added the previous reply node cannot be used so all the extra space we allocated in it is wasted. in case someone uses deffered replies in a loop, each time adding a small reply, each of these reply nodes (the small string reply) would have consumed a 16k block. now when we add anther diferred reply node, we trim the unused portion of the previous reply block. see #7123
Member
Author
|
@fayadexinqing here's the optimization to deferred replies. |
Contributor
|
Thanks @oranagra, this looks like a good idea to me. Especially because of modules. |
Contributor
|
@oranagra reviewed, looks good to me, merging. Thanks! |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Apr 28, 2020
optimize memory usage of deferred replies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deffered reply is added the previous reply node cannot be used so
all the extra space we allocated in it is wasted. in case someone uses
deffered replies in a loop, each time adding a small reply, each of
these reply nodes (the small string reply) would have consumed a 16k
block.
now when we add anther diferred reply node, we trim the unused portion
of the previous reply block.
see #7123