Modules: Do not auto-unblock clients if not blocked on keys#6922
Merged
antirez merged 1 commit intoredis:unstablefrom Feb 27, 2020
Merged
Modules: Do not auto-unblock clients if not blocked on keys#6922antirez merged 1 commit intoredis:unstablefrom
antirez merged 1 commit intoredis:unstablefrom
Conversation
Collaborator
Author
|
@antirez you had a good point in https://github.com/antirez/redis/pull/6699 - apparently some existing modules rely on the old behaviour in which clients are not automatically unblocked in unblockClientFromModule (when timedout, disconnected, etc.) |
Collaborator
|
This fixes a real regression in blocking clients API. |
Contributor
|
Thanks, merged. This PR was flagged as not ok by the actions. Waiting some time but I think we should remove it while it is totally unreliable. |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 5, 2020
Modules: Do not auto-unblock clients if not blocked on keys
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
…ound (redis#9192) fixes test issue introduced in redis#9167 1. invalid reads due to accessing non-retained string (passed as unblock context). 2. leaking module blocked client context, see redis#6922 for info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.