Make error when submitting command in incorrect context more explicit#6775
Merged
antirez merged 1 commit intoredis:unstablefrom Jan 15, 2020
Conversation
So error message `ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context` will become `ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context`
itamarhaber
approved these changes
Jan 13, 2020
antirez
added a commit
that referenced
this pull request
Jan 15, 2020
Contributor
|
Thanks @SqREL |
antirez
added a commit
that referenced
this pull request
Feb 4, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
…d-withing-context-explicit Make error when submitting command in incorrect context more explicit
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
kasiawasiuta
pushed a commit
to kasiawasiuta/redis
that referenced
this pull request
Mar 11, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 23, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding useful details for an error message when client submitting command in context, that only limited scope of commands.
An opened issue: https://github.com/antirez/redis/issues/6770
Error message
ERR only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this contextwill become
ERR 'get' command submitted, but only (P)SUBSCRIBE / (P)UNSUBSCRIBE / PING / QUIT allowed in this context