Skip to content

Mark certain configurations directives as "log-on-crash", and have it in the crash report, at the end.#6734

Closed
itamarhaber wants to merge 1 commit intoredis:unstablefrom
itamarhaber:info-dynamic-hz
Closed

Mark certain configurations directives as "log-on-crash", and have it in the crash report, at the end.#6734
itamarhaber wants to merge 1 commit intoredis:unstablefrom
itamarhaber:info-dynamic-hz

Conversation

@itamarhaber
Copy link
Member

No description provided.

@laixintao
Copy link

@itamarhaber
Copy link
Member Author

@laixintao only once this is actually merged and released.

For now, we have this: redis/redis-doc#1236

@antirez
Copy link
Contributor

antirez commented Jan 8, 2020

Hello @itamarhaber, are we sure we need this? Because we have both the configured and current HZ, so we can detect if there are changes. In case we need, I would use the use_dynamic_hz name in INFO btw.

@itamarhaber
Copy link
Member Author

Hi @antirez - no, I'm not sure we need this :) (agreeing on use_dynamic_hz)

The reason I made this is that I thought we'd like to know when someone's using dynamic_hz in crash reports. Same btw for io_threads, and its current counter, but that's buried in networking.c globals.

@antirez
Copy link
Contributor

antirez commented Jan 8, 2020

@itamarhaber I think that in the case of HZ, for debugging to know if we have or not dynamic HZ is not very important, because if there are enough clients and it is enabled, we'll see it anyway. Instead what I think should be done, is that certain configuration directives should be marked as "dump-on-crash" or alike, and we need to have a crash section where they are extracted and displayed. Because to keep adding the configuration things on INFO is not viable. Certain things that are main things like threaded or not, yep, but other stuff are useful for debugging but not really worth appearing on INFO.

@itamarhaber
Copy link
Member Author

"dump-on-crash"

I like it - kind of like the reverse of what @oranagra did for the modules INFO section. Please feel free to close this or keep it open as a TODO.

@antirez
Copy link
Contributor

antirez commented Jan 10, 2020

Thanks @itamarhaber, keeping open changing the title.

@antirez antirez changed the title Adds 'dynamic_hz' to INFO Mark certain configurations directives as "log-on-crash", and have it in the crash report, at the end. Jan 10, 2020
@oranagra
Copy link
Member

oranagra commented Aug 2, 2021

closing in favor of #9304

@oranagra oranagra closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants