Mark certain configurations directives as "log-on-crash", and have it in the crash report, at the end.#6734
Mark certain configurations directives as "log-on-crash", and have it in the crash report, at the end.#6734itamarhaber wants to merge 1 commit intoredis:unstablefrom
Conversation
|
@laixintao only once this is actually merged and released. For now, we have this: redis/redis-doc#1236 |
|
Hello @itamarhaber, are we sure we need this? Because we have both the configured and current HZ, so we can detect if there are changes. In case we need, I would use the |
|
Hi @antirez - no, I'm not sure we need this :) (agreeing on The reason I made this is that I thought we'd like to know when someone's using dynamic_hz in crash reports. Same btw for io_threads, and its current counter, but that's buried in networking.c globals. |
|
@itamarhaber I think that in the case of HZ, for debugging to know if we have or not dynamic HZ is not very important, because if there are enough clients and it is enabled, we'll see it anyway. Instead what I think should be done, is that certain configuration directives should be marked as "dump-on-crash" or alike, and we need to have a crash section where they are extracted and displayed. Because to keep adding the configuration things on INFO is not viable. Certain things that are main things like threaded or not, yep, but other stuff are useful for debugging but not really worth appearing on INFO. |
I like it - kind of like the reverse of what @oranagra did for the modules INFO section. Please feel free to close this or keep it open as a TODO. |
|
Thanks @itamarhaber, keeping open changing the title. |
INFO|
closing in favor of #9304 |
No description provided.