@itamarhaber Hi, thank you for your valuable comments, I will work on these and resolve & test these shortly..

Hi @itamarhaber Can you please review this PR again? thanks!

closing this PR since we have a more recent descussion and fix in #8000

in my eyes, redis-cli is aiming to be simple and dumb, but considering it attempts to show the currently selected db in the prompt, i think it's its job to track multi state.
maybe even show the fact you're in multi state in the prompt too.
re-opening for further discussion.

hi @oranagra , showing the multi state is a good idea in cli, it indeed give user clear idea whether it is in a transaction context, rather than checking the return value of command(will return queued). For this db number inconsistency issue, I felt like if we provide a way for fetching the current db, like #8139 or CLIENT INFO command and using this in cli when it refreshing the prompt, we shouldn't see this issue anymore. How do you think?

i don't think redis-cli needs to implicitly send commands to redis to refresh the prompt (even the initial COMMAND command it implicitly sends at startup may be problematic).
i think redis-cli needs to track the selected database on it's own.
so IMHO this PR goes the right way (tracking both client states in the client), i think it would be nice to reflect both in the prompt too.

thanks @oranagra for the advice,

i think redis-cli needs to track the selected database on it's own.

I was just not sure if this is the only case causing the db inconsistencies between cli and redis server and what we did here is just purely doing something in cli side rather than #8139 which provide a way for sync with server to get correct db number. but this pr actually fixing the issue #6727, if you think this make sense I can modify this pr, also include something like:
127.0.0.1:6379 (MULTI)[5]>
not sure the format looks ok to you, besides the db number, we can also show in a transaction state, how do you think? thanks!

seems right to me. i'd like to see what @itamarhaber thinks.
(about showing the multi-state in redis-cli with the above mentioned format)

i think redis-cli needs to track the selected database on it's own.

Agreed.

can modify this pr, also include something like: 127.0.0.1:6379 (MULTI)[5]>

Totally - a MULTI indicator would be awesome. I think that dbnum should precede it though, and for the sake of brevity I'd use something like:

hostip:port[dbnum]TX>

Thanks @oranagra @itamarhaber , based on the conversion please review my new changes of this PR, thanks!

thanks @oranagra @itamarhaber , pr updated based on the suggestions..

@Oran be my guest, please do.