Enable -a (auth) option for redis-benchmark --cluster#6665
Closed
artix75 wants to merge 1 commit intoredis:unstablefrom
Closed
Enable -a (auth) option for redis-benchmark --cluster#6665artix75 wants to merge 1 commit intoredis:unstablefrom
artix75 wants to merge 1 commit intoredis:unstablefrom
Conversation
bsergean
referenced
this pull request
in bsergean/redis
May 6, 2020
When we fetch the cluster configuration, we need to authenticate first if we are running against a password/ACL protected redis instance. Kindof a follow up to https://github.com/antirez/redis/pull/6665
Contributor
|
Hello @antirez , can you please consider merging this into 6.0? recently, we did benchmark test by using 6.0.4v on cluster mode but got the NOAUTH error when fetching cluster config ...Thanks |
Member
|
fixed by #7488 |
oshadmi
added a commit
to oshadmi/redis
that referenced
this pull request
Sep 28, 2025
$ gitlog v8.2.1..v8.2.5 redis#6867 Improve BUILD_INTEL_SVS_OPT flag validation redis#6845 Fix vector compression type reporting and rename SVS environment variable redis#6794 Fix rpcountFree casting redis#6825 Bump vecsim 8.2.4 redis#6787 Fix deadlock while RDB loading and RM_Yield (redis#6763) redis#6723 Fix ACLUserMayAccessIndex redis#6701 Fix fd leak when OOM redis#6676 bump svs version redis#6671 Add SVS-VAMANA index to info fields telemetry redis#6665 Optimize rs_wall_clock_diff_ns by removing redundant if branch redis#6641 Update vectors memory in total index info memory redis#6634 Log DocTable capacity growth for memory diagnostics redis#6649 Bump minimal redis version redis#6648 Fix "has map" performance redis#6645 Trie: hide expensive memory usage computation behind a test-specific feature flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
-aoption on redis-benchmark when it's launched in cluster mode (--clusteroption), should allow redis-benchmark to authenticate to Redis. Anyway, the authentication itself is currently performed only inside benchmark's queries.So, with password-protected cluster, fetching the initial cluster configuration would fail, since the
-aoption is actually ignored during cluster configuration fetching.This PR will let redis-benchmark to use the password specified in the
-aoption also during cluster configuration fetching, letting it work also with password-protected clusters.See https://github.com/antirez/redis/pull/5889#issuecomment-565272574