Enhance IO Threaded: use main thread to handle read/write work#6110
Merged
antirez merged 2 commits intoredis:unstablefrom Jan 13, 2020
Merged
Enhance IO Threaded: use main thread to handle read/write work#6110antirez merged 2 commits intoredis:unstablefrom
antirez merged 2 commits intoredis:unstablefrom
Conversation
Contributor
Author
|
Hi @antirez , please have a look about this PR, since we are near Redis 6 RC1 and I think threaded-io is an important feature. |
Contributor
|
I agree this should be in RC1, it's low hanging fruit that further improves performance and is much more efficient. |
madolson
approved these changes
Jan 13, 2020
Contributor
|
Hello @soloestoy, @madolson, this is a great idea. And not just because we add a new thread to our pool, this moreover avoids that the main thread waits so much time in a busy loop, that can be a problem even from the POV of the kernel scheduler. I didn't check but I imagine that, after this change, we no longer have the problem that we had before, that is: when the configured number of threads exceeded the number of cores, it was likely for the threaded implementation to be slower. Merging it right now. Thanks! |
antirez
added a commit
that referenced
this pull request
Jan 13, 2020
antirez
added a commit
that referenced
this pull request
Jan 13, 2020
antirez
added a commit
that referenced
this pull request
Feb 4, 2020
antirez
added a commit
that referenced
this pull request
Feb 4, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
Enhance IO Threaded: use main thread to handle read/write work
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Feb 20, 2020
kasiawasiuta
pushed a commit
to kasiawasiuta/redis
that referenced
this pull request
Mar 11, 2020
kasiawasiuta
pushed a commit
to kasiawasiuta/redis
that referenced
this pull request
Mar 11, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 23, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 23, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to jschmieg/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Mar 24, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Apr 29, 2020
jschmieg
pushed a commit
to pmem/redis
that referenced
this pull request
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @antirez , the Threaded IO feature has a good performance, but now it works in busy loop mode, that looks a bit wasteful, especially the main thread.
After main thread distributes IO jobs to IO threads, it can only wait until all jobs done, do nothing but loop, here I think we can use the main thread's loop time to handle the IO jobs, just take the main thread as an IO thread at this time.
I test this mode, in the write side can optimize 25% or more depends on the io-threads, but the read side doesn't optimize much, you know.