Preserve client->id for blocked clients.#6073
Merged
antirez merged 1 commit intoredis:unstablefrom May 10, 2019
Merged
Conversation
Contributor
|
Hello @yossigo, your PR looks good, but about your comment, I think that this was introduced because some module authors forget to declare the command as blocking: without such check you get a crash. Is that what you mean? Thanks. |
Contributor
|
P.S. I merged this PR regardless of our ongoing discussion @yossigo. Thank you. |
Contributor
|
PP.SS. Please would you open an issue about your other finding? |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Jul 10, 2019
Preserve client->id for blocked clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
client->idas returned byRM_GetClientId()is wrong for blocked clients.Hi @antirez I came across unclear behavior in
RM_BlockClient()which, if called from Lua or insideMULTIwill allocate and return a blocked client but return an error. As it is now it seems like a bug... I would expect the error to be immediate with no blocked client returned (NULL), is there some other (undocumented) intention to this behavior?