PSYNC2: make partial sync possible after master reboot#6034
Closed
soloestoy wants to merge 1 commit intoredis:unstablefrom
Closed
PSYNC2: make partial sync possible after master reboot#6034soloestoy wants to merge 1 commit intoredis:unstablefrom
soloestoy wants to merge 1 commit intoredis:unstablefrom
Conversation
Contributor
|
Thanks @soloestoy, I'll give it a look, if it is possible it is surely an advantage. Maybe we excluded that possibility initially because of safety concerns, so it's better to make sure no problems can happen. Thanks for bringing this up. |
Contributor
Author
|
Maybe one safety concern, an old problem: An instance reboots as a master would not load the expired keys, then if it loads the replication info and replicas has the same replication info, expired keys when loading cannot be propagated to replicas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @antirez, recently I have a talk with @braveHeart1996 about PSYNC2 who opened an issue #6030 .
Although the fix in PR #6031 is not right, but one interesting idea is that can we allow a master to load replication info?
Maybe we can load the replication info as a secondary ID and offset, just like what
replicaof no onedoes, give a chance to replicas to partial resynchronizations with the rebooted master.Just for discussion.