incrbyfloat: fix issue #5256 ttl lost after propagate#5817
incrbyfloat: fix issue #5256 ttl lost after propagate#5817soloestoy wants to merge 1 commit intoredis:unstablefrom
Conversation
|
Hello @soloestoy, thanks for this PR! I think that's going to be more complex than that :-( |
I prefer this, and some users wait this option for a long time. |
|
Awesome @soloestoy, what about |
|
Emm... seems too long? Now we have 4 options |
|
@soloestoy I don't think it's a good idea to continue with the short ones, I used NX because we historically had the "SETNX" command, then XX. EX / PX in retrospect are errors of mine, they are not understandable. UX would be IMHO the next error, so I would go for |
|
/me just realized there will never be |
|
@soloestoy are you willing to update the PR with the proposed solution, or I may do it. Asking because RC1 is very near! :-D Thanks. |
|
Thanks @soloestoy! Merged :-) Closing this. |
Fix #5256