Skip to content

incrbyfloat: fix issue #5256 ttl lost after propagate#5817

Closed
soloestoy wants to merge 1 commit intoredis:unstablefrom
soloestoy:fix-incrbyfloat-propagate
Closed

incrbyfloat: fix issue #5256 ttl lost after propagate#5817
soloestoy wants to merge 1 commit intoredis:unstablefrom
soloestoy:fix-incrbyfloat-propagate

Conversation

@soloestoy
Copy link
Contributor

@soloestoy soloestoy commented Jan 30, 2019

Fix #5256

@antirez
Copy link
Contributor

antirez commented Nov 25, 2019

Hello @soloestoy, thanks for this PR! I think that's going to be more complex than that :-(
Usually we rewrite expires as EXPIREAT in the AOF channel, and relative EXPIRE in the replication channel. So this patch would not be enough. I think we may need something else here, probably a new SET option that does not touch the expire would be ideal in such cases. What do you think?

@antirez antirez added this to the Redis 6 milestone Nov 25, 2019
@soloestoy
Copy link
Contributor Author

a new SET option that does not touch the expire would be ideal in such cases

I prefer this, and some users wait this option for a long time.

@antirez
Copy link
Contributor

antirez commented Nov 25, 2019

Awesome @soloestoy, what about KEEPTTL?

@soloestoy
Copy link
Contributor Author

soloestoy commented Nov 25, 2019

Emm... seems too long? Now we have 4 options NX|XX|EX|PX, to keep the format how about UX means Untouch eXpire

@antirez
Copy link
Contributor

antirez commented Nov 25, 2019

@soloestoy I don't think it's a good idea to continue with the short ones, I used NX because we historically had the "SETNX" command, then XX. EX / PX in retrospect are errors of mine, they are not understandable. UX would be IMHO the next error, so I would go for KEEPTTL.

@itamarhaber
Copy link
Member

/me just realized there will never be THX flag, shame

@antirez
Copy link
Contributor

antirez commented Dec 16, 2019

@soloestoy are you willing to update the PR with the proposed solution, or I may do it. Asking because RC1 is very near! :-D Thanks.

@soloestoy
Copy link
Contributor Author

Hi @antirez I open a new PR #6679 , please check ^_^

@antirez
Copy link
Contributor

antirez commented Dec 18, 2019

Thanks @soloestoy! Merged :-) Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INCRBYFLOAT is rewritten as SET command but without expire time

3 participants