Merged
Conversation
Member
|
@itamarhaber these days the doc refers to https://redis.io/topics/modules-intro for the list of format. |
Member
Author
|
@oranagra updated - please review. |
Member
|
@itamarhaber please rebase. i don't understand how come github doesn't show conflicts. |
oranagra
previously approved these changes
Sep 5, 2020
Member
|
ok. i understand why it doesn't show conflicts. RedisModule_Call(ctx,"INCRBY","sc",argv[1],"10");or a longer one like the top one in the referred docs:? reply = RedisModule_Call(ctx,"INCRBY","sc",argv[1],"10");
if (RedisModule_CallReplyType(reply) == REDISMODULE_REPLY_INTEGER) {
long long myval = RedisModule_CallReplyInteger(reply);
/* Do something with myval. */
} |
oranagra
added
the
state:to-be-merged
Member
Author
|
Added as suggested. |
oranagra
approved these changes
Sep 9, 2020
oranagra
added a commit
that referenced
this pull request
Sep 10, 2020
Improve RM_Call inline documentation about the fmt argument so that we don't completely depend on the web docs. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit ce15620)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Improve RM_Call inline documentation about the fmt argument so that we don't completely depend on the web docs. Co-authored-by: Oran Agra <[email protected]>
jschmieg
pushed a commit
to memKeyDB/memKeyDB
that referenced
this pull request
Nov 6, 2020
Improve RM_Call inline documentation about the fmt argument so that we don't completely depend on the web docs. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit ce15620)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could swear something like this used to be there, but for the life of me, I can't find it. Anyway, this is needed so the API's documentation is more complete.