Adds URI support to redis-benchmark#4507
Closed
itamarhaber wants to merge 3 commits intoredis:unstablefrom
Closed
Conversation
Member
Author
|
@artix75 as long as you're working on this already, please review this. |
oranagra
reviewed
Nov 12, 2020
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
Let's move this code into the new cli helpers file we created instead of duplicating it.
Contributor
|
@itamarhaber kind reminder about this one, given I was revising our pending issues/PRs for redis-benchmark :) Do you want me to address it? |
Member
Author
|
@filipecosta90 sure, please take it if you have the time |
Contributor
|
@itamarhaber closing this one in favor of #9314 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic copied from #3409