Fix comments of _quicklistSplitNode function.#4341
Merged
oranagra merged 3 commits intoredis:unstablefrom Sep 9, 2020
Merged
Conversation
Signed-off-by: tianhe1986 <[email protected]>
oranagra
previously approved these changes
Sep 5, 2020
oranagra
added
the
state:to-be-merged
Member
|
@tianhe1986 good catch.. this is quite hard to review since the code deals with what to delete rather than what to keep. one thing to ask before i merge this, maybe you understand why everything in the comment is written twice? |
oranagra
approved these changes
Sep 9, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 4, 2020
Comments about the behavior of the function where wrong (off by one) Co-authored-by: Oran Agra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the code, when
'after'==0, the returned node will have elements [0, OFFSET-1], and the input node keeps elements [OFFSET, END].