install redis-check-rdb as a symlink instead of duplicating the binary#3494
Closed
remicollet wants to merge 1 commit intoredis:unstablefrom
Closed
install redis-check-rdb as a symlink instead of duplicating the binary#3494remicollet wants to merge 1 commit intoredis:unstablefrom
remicollet wants to merge 1 commit intoredis:unstablefrom
Conversation
remicollet
force-pushed
the
issue-symlinklink
branch
from
0786e63 to
a34f7b1
Compare
carlwgeorge
referenced
this pull request
in iusrepo/redis32u
Jul 28, 2017
carlwgeorge
referenced
this pull request
in iusrepo/redis32u
Jul 28, 2017
Contributor
|
Oh wow! This hack has found its home in some distro packaging patches already! :) @antirez what stops you from deduplicating? |
Member
|
LGTM |
Contributor
|
Hi @remicollet, could you please do the same for |
Contributor
Author
|
@nrvnrvn this PR is open for > 2 years... so obviously upstream don't care... so won't spend more time on it |
Member
|
solved by #5745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.