Skip to content

Fix CONFIG SET for client-output-buffer-limit.#3465

Closed
malisper wants to merge 1 commit intoredis:unstablefrom
malisper:fix-client-output-buffer-limit
Closed

Fix CONFIG SET for client-output-buffer-limit.#3465
malisper wants to merge 1 commit intoredis:unstablefrom
malisper:fix-client-output-buffer-limit

Conversation

@malisper
Copy link

@malisper malisper commented Aug 21, 2016

Previously any unit for hard/soft limit (e.g. GB) would be
ignored. Additionally, you could include a unit for the time and Redis
would not give a invalid argument error.

@malisper malisper force-pushed the fix-client-output-buffer-limit branch from b988c7e to cfb0241 Compare August 21, 2016 17:50
@malisper
Fix CONFIG SET for client-output-buffer-limit.
ecd5223 
Previously any unit for hard/soft limit (e.g. GB) would be
ignored. Additionally, you could include a unit for the time and Redis
would not give a invalid argument error.
@malisper malisper force-pushed the fix-client-output-buffer-limit branch from cfb0241 to ecd5223 Compare August 21, 2016 17:53
@yoav-steinberg
Copy link
Contributor

yoav-steinberg commented Jul 29, 2021

Thanks, this is indeed a bug. It's been partially handled in 8c8e85d but not completely. Can you rebase and fix?

@yoav-steinberg yoav-steinberg added state:needs-coding the solution is trivial, some coding (or additional coding) is needed state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten labels Jul 29, 2021
@enjoy-binbin
Copy link
Contributor

enjoy-binbin commented Aug 1, 2021

I changed a version of mine. Also handle loadServerConfigFromString @yoav-steinberg WDYT?
https://github.com/redis/redis/compare/unstable...enjoy-binbin:client-output-buffer-limit?expand=1

@yoav-steinberg
Copy link
Contributor

yoav-steinberg commented Aug 3, 2021

I changed a version of mine. Also handle loadServerConfigFromString @yoav-steinberg WDYT?
https://github.com/redis/redis/compare/unstable...enjoy-binbin:client-output-buffer-limit?expand=1

@enjoy-binbin I like this. Since we got no response from the original author of this PR I suggest you create a new PR and I'll close this one.

@enjoy-binbin enjoy-binbin mentioned this pull request Aug 3, 2021
Merged
@enjoy-binbin
Copy link
Contributor

enjoy-binbin commented Aug 3, 2021

@yoav-steinberg Cool. I made a new one

@yoav-steinberg
Copy link
Contributor

yoav-steinberg commented Aug 3, 2021

Updated PR at #9308. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state:needs-coding the solution is trivial, some coding (or additional coding) is needed state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malisper @yoav-steinberg @enjoy-binbin