#3453 make global function pointers defined in redismodule.h as extern#3455
Closed
levyfan wants to merge 1 commit intoredis:unstablefrom
levyfan:module
Closed
#3453 make global function pointers defined in redismodule.h as extern#3455levyfan wants to merge 1 commit intoredis:unstablefrom levyfan:module
levyfan wants to merge 1 commit intoredis:unstablefrom
levyfan:module
Conversation
Author
|
@antirez @itamarhaber @dvirsky please have a review #3453 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global variables defined in headers will cause duplicate symbols linkage error when this header is included in multiple source files. We should declare it by extern in header and define it in c source file.
http://stackoverflow.com/questions/1433204/how-do-i-use-extern-to-share-variables-between-source-files-in-c