Conversation
|
@yoav-steinberg I think it's correct. @ushachar what do you think? |
|
@yossigo There's no need for this, there's a nodeIsSlave check at the beginning of the handling for all SETSLOT subcommands... |
|
There are quite a few more issues here as well. For 1, this is merging against Redis 3.0, which is definitely no longer supported. Some of this code is redundant. We probably just want to replace this with a new PR with the couple of fixes that are still relevant. |
The call to |
|
@yoav-steinberg I agree I think those are useful, I'll open another PR with just those fixes. |
No description provided.