Fix GEORADIUS negative unit#3194
Closed
tidwall wants to merge 1 commit intoredis:unstablefrom
tidwall:fix-georadius-negative-unit
Closed
Fix GEORADIUS negative unit#3194tidwall wants to merge 1 commit intoredis:unstablefrom tidwall:fix-georadius-negative-unit
tidwall wants to merge 1 commit intoredis:unstablefrom
tidwall:fix-georadius-negative-unit
Conversation
Contributor
|
Thanks! Fixed with a different commit because the function claims to reply on errors, so the error should be generated by the called function, not by the caller (like it happens if the double cannot be parsed). |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Aug 29, 2016
Thanks to @tidwall for reporting. Close redis#3194.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests will hang on
GEORADIUSwhen there is a negative unit specified.reproduce: