Open
Conversation
There was a problem hiding this comment.
Remove this check; it's not protecting anything, and the behaviour is not forward compatible.
In lua 5.2+:
When ptr is NULL, osize encodes the kind of object that Lua is allocating. osize is any of LUA_TSTRING, LUA_TTABLE, LUA_TFUNCTION, LUA_TUSERDATA, or LUA_TTHREAD when (and only when) Lua is creating a new object of that type. When osize is some other value, Lua is allocating memory for something else.
|
Dov Kfir seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua memory usage is not limited and a script can crash redis.
The issue is solved with the addition of new memory allocator that uses a new configurable lua-memory-limit.
Implementation details:
currently we are using Lua 5.1.5. In this version the GC cannot be called from within the allocator, thus scripts that doesn't suppose to cross the memory limit can fail on low memory,
Scenarios:
to improve the first scenario we added a new configurable lua-gc-threshold, which is tested before we run the script, if the Lua stack cross the threshold we initiate GC cycle to release some memory.
the second issue was resolved in Lua 5.2 with the emergency garbage collector feature and memory limit gc parameter.