use bit hack in _dictNextPower#2382
Closed
oranagra wants to merge 1 commit intoredis:unstablefrom
oranagra:bit_hack_dictNextPower
Closed
use bit hack in _dictNextPower#2382oranagra wants to merge 1 commit intoredis:unstablefrom oranagra:bit_hack_dictNextPower
oranagra wants to merge 1 commit intoredis:unstablefrom
oranagra:bit_hack_dictNextPower
Conversation
Contributor
|
This makes no difference at all , practically ;-) And is more complex. It is worth it when you have to compute a lot of next power ops, but here, you do that only during rehashing or alike, it will never be measurable. Simpler code instead is measurably better. Thanks anyway! |
Member
Author
|
ok, but please notice what i said about LONG_MAX (not a power of 2 at all) |
Contributor
|
Yeah, that's been a bug forever. The proper value would be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using bit hack to find the next power of 2.
also notice that LONG_MAX (previously used) was not a power of 2 at all.