Fix compile on some linux distros#15225
Merged
Merged
Conversation
Co-authored-by: debing.sun <[email protected]>
sundb
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
pathbeing NULL inmoduleLoadInternalModules().(reported on Ubuntu 20.04)
Co-authored-by: debing.sun [email protected]
Note
Low Risk
Low risk: changes are limited to build flags and compiler-version guards, plus a minor log formatting fix when
pathcan be NULL.Overview
Improves build compatibility on some Linux toolchains by adding
-ffat-lto-objectsalongside GCC-flto=auto, letting linkers fall back to non-LTO objects when needed.Adjusts GCC-version guards in
deps/trexmalloc.cto avoid warnings on older GCC (moves__attribute__((access))to GCC 11+ and only suppresses-Wuse-after-freeon GCC 12+). Also makes the module load failure log inmoduleOnLoadhandle a NULLpath(internal modules) without warnings.Reviewed by Cursor Bugbot for commit 394bb0c. Bugbot is set up for automated code reviews on this repo. Configure here.