GCRA param renaming#14950
Merged
Merged
Conversation
Collaborator
Author
|
@sundb FYI PM wanted this. |
🤖 Augment PR SummarySummary: This PR renames GCRA command parameters to use “tokens” terminology instead of “requests”. Changes:
Technical Notes: The change touches both the generated command table and the JSON command spec used by 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
minchopaskal
force-pushed
the
gcra-rename
branch
from
4005b34 to
1a0eb2c
Compare
sundb
approved these changes
Mar 31, 2026
sundb
left a comment
sundb
left a comment
Collaborator
There was a problem hiding this comment.
dont forget to update the top comment
sundb
added
the
release-notes
mgravell
added a commit
to StackExchange/StackExchange.Redis
that referenced
this pull request
Apr 7, 2026
… a new CI build before we can validate this)
michael-grunder
added a commit
to phpredis/phpredis
that referenced
this pull request
Apr 7, 2026
michael-grunder
added a commit
to phpredis/phpredis
that referenced
this pull request
Apr 8, 2026
pierluigilenoci
pushed a commit
to pierluigilenoci/redis
that referenced
this pull request
Apr 16, 2026
Renames the `GCRA` command interface to use token terminology: `requests-per-period` becomes `tokens-per-period`, and the optional `NUM_REQUESTS` argument becomes `TOKENS` (with corresponding error messages/documentation updates).
mgravell
added a commit
to StackExchange/StackExchange.Redis
that referenced
this pull request
Apr 21, 2026
* GCRA: reflect name/protocol change from redis/redis#14950 (note: need a new CI build before we can validate this) * PR number * CI version * more CI version
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title
Note
Medium Risk
Changes the public
GCRAcommand argument names/tokens, which is backward-incompatible for clients/scripts even though underlying rate-limiting math is unchanged.Overview
Renames the
GCRAcommand interface to use token terminology:requests-per-periodbecomestokens-per-period, and the optionalNUM_REQUESTSargument becomesTOKENS(with corresponding error messages/documentation updates).Updates the implementation variable names and overflow/syntax checks accordingly, and adjusts unit tests and command metadata (
commands.def,commands/gcra.json) to match the new argument names.Written by Cursor Bugbot for commit 1a0eb2c. This will update automatically on new commits. Configure here.