Fix loading old version node.conf without shard_id#14495
Merged
ShooterIT merged 1 commit intoredis:unstablefrom Nov 1, 2025
Merged
Fix loading old version node.conf without shard_id#14495ShooterIT merged 1 commit intoredis:unstablefrom
ShooterIT merged 1 commit intoredis:unstablefrom
Conversation
ShooterIT
added
the
release-notes
tezc
reviewed
Oct 31, 2025
tezc
approved these changes
Oct 31, 2025
ShooterIT
added this to
Redis 8.0 Backport, Redis 8.2 Backport, Redis 7.2 Backport, Redis 8.4 and Redis 7.4 Backport
sundb
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will generate a random shard id when creating a cluster node, so
auxFieldHandlers[af_shard_id].isPresent(n) == 0never meet, so it means we never add master nodes intocluster.shardswhen loading, this bug is introduced in Introduce Shard IDs to logically group nodes in cluster mode #10536 that supportsshard-idconcept. BTW, Avoid cluster.nodes load corruption due to shard-id generation #13468 can make replicas add intocluster.shardsReplica shard_id may be different with master, so before we add again, we should remove it, otherwise,
cluster.shardswill have dirty shards, introduced in Avoid cluster.nodes load corruption due to shard-id generation #13468These bugs causes the output of the
cluster shardsis corrupt, the temporaryslot_infomay not be cleaned up, we may see the duplicated slot ranges, and a shard info without master.test locally, maybe we need add tcl test cases later