Fix: build flags for dependencies #14038
Merged
minchopaskal merged 2 commits intoredis:unstablefrom May 13, 2025
Merged
Conversation
sundb
approved these changes
May 13, 2025
Collaborator
tezc
reviewed
May 13, 2025
tezc
approved these changes
May 13, 2025
Collaborator
tezc
left a comment
tezc
left a comment
There was a problem hiding this comment.
LGTM! We don't have a similar problem for other dependencies right?
Collaborator
Author
Yep, we don't pass DEPS_CFLAGS to jemalloc, also not directly to lua. As for the rest of the dependancies - their Makefiles are written in such a way that allows passing CFLAGS/LDFLAGS from outside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13916 introduced a regression - by overriding the
CFLAGSandLDFLAGSvariables for all of the dependencies hiredis and fast_float lost some of their compiler/linker flags.This PR makes it so we can pass additional CFLAGS/LDFLAGS to hiredis, without overriding them as it contains a bit more complex Makefile. As for fast_float - passing CFLAGS/LDFLAGS from outside now doesn't break the expected behavior.
The build step in the CI was changed so that the MacOS is now build with TLS to catch such errors in the future.